Skip to content

Separate task rundir and task sandbox#3315

Open
andre-merzky wants to merge 35 commits intodevelfrom
fix/sandbox
Open

Separate task rundir and task sandbox#3315
andre-merzky wants to merge 35 commits intodevelfrom
fix/sandbox

Conversation

@andre-merzky
Copy link
Copy Markdown
Member

This fixes #3292. The default behavior did not change. If a TD specifies a sandbox though, then the auxilliary RP files (profile, shell script, etc) will remain in the default location ($RP_PILOT_SANDBOX/$RP_TASK_ID), while all other actions (pwd, staged files etc) will respect the sandbox.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2025

Codecov Report

❌ Patch coverage is 54.76190% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.64%. Comparing base (b9998f7) to head (e05f11f).
⚠️ Report is 207 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/pilot/agent/executing/flux.py 18.18% 9 Missing ⚠️
src/radical/pilot/session.py 12.50% 7 Missing ⚠️
src/radical/pilot/agent/executing/popen.py 75.00% 4 Missing ⚠️
src/radical/pilot/agent/agent_0.py 50.00% 3 Missing ⚠️
src/radical/pilot/agent/executing/base.py 83.33% 3 Missing ⚠️
src/radical/pilot/task.py 50.00% 3 Missing ⚠️
src/radical/pilot/agent/launch_method/mpiexec.py 60.00% 2 Missing ⚠️
src/radical/pilot/tmgr/scheduler/base.py 0.00% 2 Missing ⚠️
src/radical/pilot/agent/executing/dragon.py 0.00% 1 Missing ⚠️
src/radical/pilot/agent/launch_method/mpirun.py 50.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3315      +/-   ##
==========================================
- Coverage   43.67%   43.64%   -0.03%     
==========================================
  Files          97       97              
  Lines       11662    11707      +45     
==========================================
+ Hits         5093     5110      +17     
- Misses       6569     6597      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep info about output files within sandbox

1 participant