Fix Executable command building

[AymenFJA]

1-Uses shelx to break down the executable and the args required by RHAPSODY 2-Add more tests for this case
3-Add more defensive error raising and remove unnecessary ones

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines how executable commands are handled within the workflow manager. By integrating shlex, it ensures that command strings are accurately parsed into their executable component and a list of arguments, improving the reliability of command execution. The changes also streamline error validation and introduce new tests to cover a wider range of command parsing scenarios.

Highlights

• Executable Command Parsing: Implemented shlex to correctly parse executable commands and their arguments, separating the executable path from its arguments for more robust execution.
• Improved Error Handling: Enhanced defensive error raising for executable tasks, ensuring that executable_task functions return non-empty command strings, and removed redundant validation checks.
• Comprehensive Testing: Added a new dedicated test file with extensive unit tests covering various shlex splitting scenarios, including quoted arguments and paths with spaces, as well as error conditions for invalid command strings.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/radical/asyncflow/workflow_manager.py
  • Imported the shlex module for command-line parsing.
  • Modified the async_wrapper to use shlex.split for executable tasks, separating the command into the executable path and its arguments.
  • Added new validation checks in async_wrapper to ensure executable tasks return a non-empty command string.
  • Removed redundant validation for executable values from the _register_component method, as these checks are now performed earlier.
• tests/unit/test_executable_task.py
  • Added a new test file to specifically test the shlex splitting behavior for executable tasks.
  • Included tests for simple command splitting, commands with no arguments, multiple arguments, and arguments with quotes.
  • Added tests for executable paths containing spaces.
  • Implemented tests for error cases where executable tasks return None, an empty string, or a whitespace-only string.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request effectively refactors the executable command building logic by integrating shlex.split for robust parsing of commands and their arguments. This change correctly separates the executable from its arguments, handling various scenarios including quoted strings and paths with spaces. The addition of comprehensive unit tests for different splitting behaviors and error cases significantly improves the reliability and test coverage of this functionality. The removal of redundant validation logic in _register_component is also a positive change, as the validation is now handled more defensively at the point of command parsing.

[andre-merzky]

This looks reasonable I think.