Skip to content

move python version to 3.8#203

Merged
andre-merzky merged 2 commits intodevelfrom
fix/py_version
Apr 3, 2025
Merged

move python version to 3.8#203
andre-merzky merged 2 commits intodevelfrom
fix/py_version

Conversation

@andre-merzky
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.15%. Comparing base (d97e0e6) to head (f3d0794).
Report is 10 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #203      +/-   ##
==========================================
+ Coverage   21.70%   23.15%   +1.44%     
==========================================
  Files           7        7              
  Lines        1170     1192      +22     
==========================================
+ Hits          254      276      +22     
  Misses        916      916              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

with:
fetch-depth: 2
- name: Set up Python 3.7
- name: Set up Python 3.9
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andre-merzky, the PR mentions 3.8, and the changes show 3.9?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I hope I did that consistently over the modules. So the test matrix now starts at 3.8 and setup.py is stating that as min version etc - but the default tests are on a somewhat newer versions. Even 3.9 is officially not supported anymore (https://devguide.python.org/versions/)...

Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andre-merzky andre-merzky merged commit 6ca50f5 into devel Apr 3, 2025
4 checks passed
@andre-merzky andre-merzky deleted the fix/py_version branch April 3, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants