Conversation
- Adds radical.edge rose plugin - ROSE Rest API via the introduced plguin
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the foundational components for a new ROSE Service, designed to streamline the management and execution of active learning workflows. It establishes a robust system for submitting, monitoring, and controlling these workflows through various interfaces, including a command-line tool, a Python client library, and a powerful integration with the RADICAL-Edge framework via a dedicated plugin. This enhancement significantly improves the usability and extensibility of ROSE by providing flexible interaction patterns and enabling embedded workflow execution within a distributed edge computing environment. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request appears to resolve merge conflicts and integrates a number of significant features and refactorings. Key changes include the introduction of a new tracking system with TrackerBase, MLflowTracker, and ClearMLTracker; a new service-based architecture for workflow management; and a major API change for parallel learners to use async iterators for streaming results. The codebase has also been updated to require Python 3.10+, with corresponding syntax and dependency updates. The changes are extensive but seem well-implemented, with accompanying documentation and test updates. My main concern is with the .pre-commit-config.yaml file, where several of the specified hook revisions appear to be invalid, which would break the pre-commit setup.
I am having trouble creating individual review comments. Click here to see my feedback.
.pre-commit-config.yaml (8)
The specified revision v1.7.7 for docformatter could not be found in the public repository. This will cause pre-commit install to fail. The latest known version is v1.7.5. Please verify the correct revision.
rev: v1.7.5.pre-commit-config.yaml (16)
The specified revision v0.13.1 for ruff-pre-commit could not be found in the public repository. This will cause pre-commit install to fail. The latest known version is v0.4.4. Please verify the correct revision.
rev: v0.4.4.pre-commit-config.yaml (27)
The specified revision v6.0.0 for pre-commit-hooks could not be found in the public repository. This will cause pre-commit install to fail. The latest known version is v4.6.0. Please verify the correct revision.
rev: v4.6.0.pre-commit-config.yaml (40)
The specified revision v1.7.7 for actionlint could not be found in the public repository. This will cause pre-commit install to fail. The latest known version is v1.7.1. Please verify the correct revision.
rev: v1.7.1.pre-commit-config.yaml (45)
The specified revision 0.34.0 for check-jsonschema could not be found in the public repository. This will cause pre-commit install to fail. The latest known version is 0.28.3. Please verify the correct revision.
rev: 0.28.3.pre-commit-config.yaml (51)
The specified revision v1.36.2 for typos could not be found in the public repository. This will cause pre-commit install to fail. The latest known version is v1.21.0. Please verify the correct revision.
rev: v1.21.01-Fix pre-commits 2-Sets the RAAS branch up to data with main new changes
No description provided.