Conversation
|
Hey @mgoliyad, thanks for the hard work. A few things to refine this PR which are unrelated to the core DDMD or ROSE work: 1- Create Each test function must start with I also left a few comments about the deployment work of the repo. Glad to explain more/help if needed. |
pyproject.toml
Outdated
| readme = "README.md" | ||
| requires-python = ">=3.9" | ||
|
|
||
| dependencies = ["rose", "radical.asyncflow", "radical.pilot"] |
There was a problem hiding this comment.
You only need to add rose, and it should be from the GitHub link ATM, as we do not have a release.
By default, Rose will install asyncflow and radical.pilot
| "pytest-cov" | ||
| ] | ||
|
|
||
| doc = [ |
There was a problem hiding this comment.
I see docs, but no documentation was provided. Is it going to be in the next dev. cycle?
There was a problem hiding this comment.
yes, I want to have good use case and then decide what to put in docs
There was a problem hiding this comment.
@mgoliyad Documentation is essential for enabling users (even if you do not have active users for now) to understand how to interact with the API and other parts of the tool. It's important to build it proactively, rather than waiting for a specific use case to emerge. Thanks :)
| pass | ||
|
|
||
|
|
||
| # @pytest.fixture |
There was a problem hiding this comment.
if this code is not used, you can remove it.
|
I will continue the review today. |
Please review new version of DDMD based on ROSE framework.
I have prepared dummy use case in
examples/dummy_pipeline
To run it:
python run_dummy_pipeline.py
or
sbatch anvil_CPU_sbatch.sh