Skip to content

Eoc 2.0.0 - #106

Merged
freddym-rl merged 33 commits into
masterfrom
eoc-2.0.0
Aug 11, 2026
Merged

Eoc 2.0.0#106
freddym-rl merged 33 commits into
masterfrom
eoc-2.0.0

Conversation

@freddym-rl

Copy link
Copy Markdown
Contributor

No description provided.

abdelkrim-djebbar and others added 30 commits October 29, 2025 14:44
Co-authored-by: Copilot <copilot@github.com>
@freddym-rl
freddym-rl requested a review from pgodey August 10, 2026 16:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the eoc Helm chart for the 2.0.0 release by introducing new deployable components (worker + optional MCP), adding cloud provider account configuration, and making replica counts configurable via values.

Changes:

  • Bump chart version/appVersion to 2.0.0.
  • Add Worker Deployment/Service/ConfigMap and add optional MCP Deployment/Service/ConfigMap.
  • Add cloudProviderAccounts values + helpers and wire CLOUD_PROVIDER_ACCOUNTS into backend/orchestrator; make UI/backend/orchestrator replicas configurable.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
charts/eoc/values.yaml Adds cloudProviderAccounts, worker, mcp, and replica values for ui/backend/orchestrator.
charts/eoc/templates/worker_service.yaml Introduces a Service for the new worker component.
charts/eoc/templates/worker_deployment.yaml Introduces a Deployment for the new worker component.
charts/eoc/templates/worker_configmap.yaml Introduces a ConfigMap to share backend-like settings with the worker.
charts/eoc/templates/ui_deployment.yaml Switches UI replica count to be values-driven.
charts/eoc/templates/backend_deployment.yaml Switches backend replica count to be values-driven.
charts/eoc/templates/orchestrator_deployment.yaml Switches orchestrator replica count to be values-driven.
charts/eoc/templates/backend_configmap.yaml Adds CLOUD_PROVIDER_ACCOUNTS and feature-flag env vars to backend.
charts/eoc/templates/orchestrator_configmap.yaml Adds CLOUD_PROVIDER_ACCOUNTS (with credentials) to orchestrator.
charts/eoc/templates/mcp_service.yaml Adds a Service for the optional MCP component.
charts/eoc/templates/mcp_deployment.yaml Adds a Deployment for the optional MCP component.
charts/eoc/templates/mcp_configmap.yaml Adds a ConfigMap for the optional MCP component.
charts/eoc/templates/_helpers.tpl Adds worker/mcp naming helpers and cloudProviderAccounts JSON helpers.
charts/eoc/Chart.yaml Bumps chart and app versions to 2.0.0.
.gitignore Adds local development directories to ignore list.
.github/workflows/release-beta.yml Adds a beta chart release workflow for the eoc-2.0.0 branch.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread charts/eoc/templates/worker_configmap.yaml
Comment thread charts/eoc/values.yaml Outdated
Comment thread charts/eoc/templates/worker_deployment.yaml
@freddym-rl
freddym-rl requested a review from jmcorne August 11, 2026 12:03
freddym-rl and others added 2 commits August 11, 2026 14:14
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.

Suppressed comments (4)

charts/eoc/values.yaml:23

  • The example and description here imply putting long-lived access tokens into values.yaml. Even as comments, this encourages committing secrets to git; it would be safer to explicitly call out using Secrets/external secret injection and avoiding committing credentials.
## Cloud Provider Accounts Configuration
## This configuration will be converted to JSON and set as CLOUD_PROVIDER_ACCOUNTS env var
## For backend: credential block will be excluded
## For orchestrator: full configuration including credentials will be included

charts/eoc/templates/worker_service.yaml:4

  • Kubernetes resource names are limited to 63 characters; appending "-service" can push the Service name over the limit when the release/chart name is long. Consider using the worker fullname directly as the Service name.
  name: {{ include "eoc-worker.fullname" . }}-service

charts/eoc/templates/worker_service.yaml:7

  • Service port names must be a short DNS label (max 15 chars). Using the full release/chart-derived name here can exceed that limit and cause Service creation to fail.
    - name: {{ include "eoc-worker.fullname" . }}-service-port

charts/eoc/templates/worker_deployment.yaml:32

  • The worker Service targets port 3000 and the health probes also use 3000, but the declared containerPort is 80. Even though containerPort is metadata, keeping it aligned avoids confusion and makes named ports/targetPort-by-name possible.
        ports:
        - containerPort: 80
        envFrom:

Comment thread charts/eoc/templates/orchestrator_configmap.yaml
@freddym-rl
freddym-rl requested a review from r1saas August 11, 2026 12:24
@freddym-rl
freddym-rl merged commit 8bcaecc into master Aug 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants