Skip to content

Conversation

@ecdaero
Copy link
Contributor

@ecdaero ecdaero commented Nov 26, 2024

Proposed Changes

This changes the line openssl x509 -in path/to/cert.pem -nameopt RFC2253 -subject -noout to put the -in parameter at the end of the line, so that it's easier to ^W the path and replace it with another path.

Tested that this works with OpenSSL 3.1.6 4 Jun 2024 (Library: OpenSSL 3.1.6 4 Jun 2024) and OpenSSL 3.3.0 9 Apr 2024 (Library: OpenSSL 3.3.0 9 Apr 2024) on an Ubuntu 22.04.4 container and MacOS 14.7.1

Types of Changes

This is a single line documentation change to deps/rabbitmq_auth_mechanism_ssl/README.md

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

This is a trivial commit that I hope will be accepted for convenience. Thank you!

This changes the line `openssl x509 -in path/to/cert.pem -nameopt RFC2253 -subject -noout` to put the `-in` parameter at the end of the line, so that it's easier to ^W the path and replace it with my own.

Tested that this works with OpenSSL 3.1.6 4 Jun 2024 (Library: OpenSSL 3.1.6 4 Jun 2024) and OpenSSL 3.3.0 9 Apr 2024 (Library: OpenSSL 3.3.0 9 Apr 2024) on an Ubuntu 22.04.4 container and MacOS 14.7.1
@pivotal-cla
Copy link

@ecdaero Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@michaelklishin
Copy link
Collaborator

@pivotal-cla this is an obvious fix

@pivotal-cla
Copy link

@ecdaero This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@michaelklishin michaelklishin merged commit 5499d50 into rabbitmq:main Nov 26, 2024
2 checks passed
@michaelklishin
Copy link
Collaborator

@Mergifyio backport v4.0.x

@mergify
Copy link

mergify bot commented Nov 26, 2024

backport v4.0.x

✅ Backports have been created

michaelklishin added a commit that referenced this pull request Nov 26, 2024
Update rabbitmq_auth_mechanism_ssl/README.md so openssl command is easier to change after pasting. (backport #12822)
@michaelklishin
Copy link
Collaborator

Ah, this is a command that inspects an already generated certificate. In any case, I will update the README to mention tls-gen.

michaelklishin added a commit that referenced this pull request Nov 26, 2024
michaelklishin added a commit that referenced this pull request Nov 26, 2024
References #12822

(cherry picked from commit e27be61)
@michaelklishin michaelklishin added this to the 4.1.0 milestone Nov 26, 2024
@ecdaero
Copy link
Contributor Author

ecdaero commented Nov 27, 2024

Excellent, thank you!

@ecdaero ecdaero deleted the rabbitmq_auth_mechanism_ssl-readme-tweak branch November 27, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants