Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP By @Ayanda-D: Ensure only alive leaders and followers when fetching QQ replica states #12727

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

michaelklishin
Copy link
Member

@michaelklishin michaelklishin commented Nov 14, 2024

This is #12709 by @Ayanda-D with individual commits cherry-picked so that Actions run with my permissions for secrets.

when checking replica states to help avoid missing
inactive replicas e.g. on QQ checks from cli tools

(cherry picked from commit 4914850)
and ensure non-existent/inactive/noproc QQ members are
not reported.

(cherry picked from commit 4e2c62b)
rabbit_quorum_queue:all_replica_states/0

(cherry picked from commit 19cc2d0)
@michaelklishin michaelklishin added this to the 4.1.0 milestone Nov 14, 2024
@michaelklishin michaelklishin changed the title By @Ayanda-D: Ensure only alive leaders and followers when fetching QQ replica states WIP By @Ayanda-D: Ensure only alive leaders and followers when fetching QQ replica states Nov 14, 2024
@michaelklishin
Copy link
Member Author

gmake ct-unit_quorum_queue

fails repeatably, both on Actions and for locally for me, with

Node: rabbit_shard1@localhost
Case: unit_quorum_queue_SUITE:all_replica_states_includes_nonvoters
Reason: {error,
            {{badmatch,{rabbit_shard1@localhost,#{}}},
             [{unit_quorum_queue_SUITE,all_replica_states_includes_nonvoters,
                  1,
                  [{file,"unit_quorum_queue_SUITE.erl"},{line,111}]},
              {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
              {test_server,run_test_case_eval1,6,
                  [{file,"test_server.erl"},{line,1302}]},
              {test_server,run_test_case_eval,9,
                  [{file,"test_server.erl"},{line,1234}]}]}}

Node: rabbit_shard4@localhost
Case: mirrored_supervisor_SUITE:{end_per_group,broker_tests,[]}
Reason: {error,
            {{assertEqual,
                 [{module,rabbit_ct_broker_helpers},
                  {line,1218},
                  {expression,"CrashesCount"},
                  {expected,0},
                  {value,21}]},
             [{rabbit_ct_broker_helpers,find_crashes_in_logs,2,
                  [{file,"rabbit_ct_broker_helpers.erl"},{line,1218}]},
              {rabbit_ct_broker_helpers,stop_rabbitmq_nodes,1,
                  [{file,"rabbit_ct_broker_helpers.erl"},{line,1174}]},
              {rabbit_ct_helpers,run_steps,2,
                  [{file,"rabbit_ct_helpers.erl"},{line,136}]},
              {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
              {test_server,run_test_case_eval1,6,
                  [{file,"test_server.erl"},{line,1390}]},
              {test_server,run_test_case_eval,9,
                  [{file,"test_server.erl"},{line,1234}]}]}}

@michaelklishin michaelklishin marked this pull request as draft November 14, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants