CQ: Fix flakes in the store file scan test (backport #12721) #12724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
We don't expect random bytes to be there in the current version of the message store as we overwrite empty spaces with zeroes when moving messages around. We also don't expect messages to be false flagged when the broker is running because it checks for message validity in the index. Therefore make sure message bodies in the tests don't contain byte 255. (cherry picked from commit db50739)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't expect random bytes to be there in the current version of the message store as we overwrite empty spaces with zeroes when moving messages around.
This fixes a very rare flake.
This is an automatic backport of pull request #12721 done by Mergify.