Make it possible to set some node-specific metadata using tags #12702
+53
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonUnge
force-pushed
the
su_aws/node_tags
branch
from
1f92e00
to
3d35416
Compare
michaelklishin
changed the title
…eleased 4.0.x nodes In a mixed cluster environment, 'rabbitmq-diagnostics status' can hit a node that does not return any node tags. Be more defensive and handle such cases by simply displaying "(none)" for such values.
michaelklishin
approved these changes
Nov 11, 2024
12 tasks
michaelklishin
added a commit
that referenced
this pull request
Nov 12, 2024
michaelklishin
added a commit
that referenced
this pull request
Nov 12, 2024
Make it possible to set some node-specific metadata using tags (backport #12702)
michaelklishin
added a commit
that referenced
this pull request
Nov 12, 2024
michaelklishin
added a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit aba62b9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #12699 but node specific.
Proposed Changes
Config node tags in config file. Store as application setting and expose them via /api/overview and rabbitmqctl status command.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.