fix setting pause symbol for non-kana symbol#8
Open
sophiefy wants to merge 1 commit into
Open
Conversation
tsukumijima
pushed a commit
to tsukumijima/open_jtalk
that referenced
this pull request
Jul 29, 2024
* Add: 辞書コンパイルに-qを追加 * Delete: 関数のquietオプションを削除 * Fix: quietオプションが残っているのを修正 * Fix: quiet引数を使っていたのを修正 * Fix: thread_localのフォールバックを追加 * Fix: msvcでの動作を修正 * Update src/mecab/src/dictionary_generator.cpp Co-authored-by: Hiroshiba <hihokaruta@gmail.com> * Delete: thread_localを削除 * Change: CHECK_DIEはquietでも出るように * Fix: まだ出力が出ていたのを修正 * cerr2箇所を戻す --------- Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe this is more of a problem with the dictionary...
njd_set_pronunciationsetsread,pronand other features for symbols with 0 mora size. Specifically, non-kana symbols will be set as読点.In the following example,
~is incorrectly parsed as名詞using MeCab and naist-jdic (whereas it should be助詞).Since its mora size is 0, its
read,pronare set to、andposis set to記号. Consequently, its features would be the following, which is weird.So I think
pos_group,ctypeandcformshould also be modified and its features become: