Skip to content

Sync fork - #289

Closed
coolusaHD wants to merge 26 commits into
r0adkll:masterfrom
coolusaHD:master
Closed

coolusaHD wants to merge 26 commits into
r0adkll:masterfrom
coolusaHD:master

Conversation

@coolusaHD

Copy link
Copy Markdown

No description provided.

coolusaHD and others added 26 commits September 11, 2024 13:53
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Also run PR validation on Node 24 with current actions.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The fork branch behind PR r0adkll#289 branched off upstream at 08b898d and has
since fallen ~25 commits behind. Everything it proposed has already landed
upstream in a more complete form:

- action.yml already runs on node24 (r0adkll#259)
- @googleapis/androidpublisher is at ^35.3.0 upstream vs ^22.0.0 here
- @actions/core already bumped for Node 24 (r0adkll#275)
- github-action-ts-run-api is already at ^3.1.0
- tj-actions/verify-changed-files is already at v20, and the
  `steps.verify-changed-files` -> `steps.verify-built-lib` step-id typo in
  pr-validation.yml is already fixed

What was left was local debugging leftovers that must not be merged:
core.debug() calls converted to core.info(), dumps of the whole options
object (which includes the GoogleAuth credential) into the workflow log,
JSON.stringify of API responses, and a try/catch/finally around the debug
symbols upload that swallowed the error and continued.

Conflicts in pr-validation.yml, release.yml, action.yml, package.json,
package-lock.json, lib/index.js, src/edits.ts, src/main.ts and
src/whatsnew.ts are all resolved in favour of upstream.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014RrXnn4a7oYgMBwJnb4Zc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants