Skip to content

merge.sf rename a geometry column (e.g. geom) to 'geometry' #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

merge.sf rename a geometry column (e.g. geom) to 'geometry' #2334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 21 additions & 23 deletions R/sf.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,31 +124,28 @@ st_geometry.sfg = function(obj, ...) st_sfc(obj)
`st_geometry<-` = function(x, value) UseMethod("st_geometry<-")

#' @export
`st_geometry<-.data.frame` = function(x, value) {
stopifnot(inherits(value, "sfc") || is.character(value))
if (inherits(value, "sfc"))
stopifnot(nrow(x) == length(value))
if (is.character(value))
st_sf(x, sf_column_name = value)
else {
a = vapply(x, function(v) inherits(v, "sfc"), TRUE)
if (any(a)) {
w = which(a)
sf_col = attr(x, "sf_column")
if (! is.null(sf_col))
x[[ sf_col ]] = value
else {
if (length(w) > 1)
warning("overwriting first sfc column")
x[[ which(a)[1L] ]] = value
}
} else
x$geometry = value
st_sf(x)
}
`st_geometry<-.data.frame` <- function (x, value) {
stopifnot(inherits(value, "sfc") || is.character(value))
if (inherits(value, "sfc"))
stopifnot(nrow(x) == length(value))
if (is.character(value))
st_sf(x, sf_column_name = value)
else {
a = vapply(x, function(v) inherits(v, "sfc"), TRUE)
sf_col = attr(x, "sf_column")
if (!is.null(sf_col))
x[[sf_col]] = value
else if (any(a)) {
w = which(a)
if (length(w) > 1)
warning("overwriting first sfc column")
x[[which(a)[1L]]] = value
}
else x$geometry = value
st_sf(x)
}
}


#' @export
`st_geometry<-.sf` = function(x, value) {
if (! is.null(value)) {
Expand Down Expand Up @@ -457,6 +454,7 @@ merge.sf = function(x, y, ...) {
class(ret) = setdiff(class(ret), "sf")
g = ret[[sf_column]] # may have NULL values in it
ret[[sf_column]] = NULL
attr(ret, "sf_column") <- sf_column
st_set_geometry(ret, st_sfc(g)) # FIXME: set agr
}

Expand Down