Dots in rename #2038
Merged
Dots in rename #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes r-lib#1969. After digging into this a little, I think making sure everything is committed is enough. use_r() won't create a file with a `.` in it, so, unless you want to let this snowball, I think the check is enough.
|
Oops, I forgot I copy/pasted that! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for uncommitted changes before renaming files, and only remove
.Rfile extensions inoldandnew.Fixes #1969.
I think this is the least-surprising approach to take. It's probably best to just not use
.in filenames, but this will stop things from breaking in confusing ways when people do.