Indicate argument type #1940
Merged
Indicate argument type #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clear that `min_version` expects a character vector, and not a double/integer when specifying exact versions.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On several occasions now I have tried to add a minimum package version using a
doublelike so:Each time I get an error, as I incorrectly guessed that
min_versionwould require a numeric type. While I think the error message is helpful enough (Error: unexpected numeric contstant in "usethis...), I think the documentation could be improved.Currently, it is only clear that
min_versionshould be a character vector when looking at the examples. The parameter documentation is not clear in and of itself.