More upkeep polishing #1909
More upkeep polishing #1909
Conversation
|
I don't know if it is related, but maybe removing unnecessary suggests dependencies such as crayon, covr, ellipsis, roxygen2, devtools etc. would be good practice since github actions handles test coverage, and covr is installed via gh action specifically. |
|
@olivroy this is specifically for our internal upkeep process, where I don't think unneeded dependencies tend to be much of a problem. |
| @@ -112,8 +112,6 @@ release_checklist <- function(version, on_cran) { | |||
| Check if any deprecation processes should be advanced, as described in \\ | |||
| [Gradual deprecation](https://lifecycle.r-lib.org/articles/communicate.html#gradual-deprecation)", | |||
| type != "patch" && has_lifecycle), | |||
| todo("Bump required R version in DESCRIPTION to {tidy_min_r_version}", | |||
There was a problem hiding this comment.
Now in upkeep, rather than release.
There was a problem hiding this comment.
I kinda like it as part of the release checklist, but not a hill I will die on.
There was a problem hiding this comment.
I don't have strong feelings either except that it should be in one or the other.
| expect_snapshot( | ||
| writeLines(tidy_upkeep_checklist(posit_pkg = TRUE, posit_person_ok = FALSE)), | ||
| transform = scrub_checklist_footer | ||
| local_mocked_bindings( |
There was a problem hiding this comment.
I probably should've done this in a separate PR, but using mocking for everything makes the tests quite a bit simpler.
| @@ -112,8 +112,6 @@ release_checklist <- function(version, on_cran) { | |||
| Check if any deprecation processes should be advanced, as described in \\ | |||
| [Gradual deprecation](https://lifecycle.r-lib.org/articles/communicate.html#gradual-deprecation)", | |||
| type != "patch" && has_lifecycle), | |||
| todo("Bump required R version in DESCRIPTION to {tidy_min_r_version}", | |||
There was a problem hiding this comment.
I kinda like it as part of the release checklist, but not a hill I will die on.
No description provided.