Improvements to standalone header #1903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
krlmlr
commented
Oct 22, 2023
krlmlr
commented
- Use correct host and ref in URL
- Add "generated by" code
jennybc
reviewed
Jul 24, 2024
| ref_string <- ref %||% "HEAD" | ||
| host_string <- host %||% "https://github.com" | ||
| source_comment <- | ||
| glue("# Source: {host_string}/{repo_spec}/blob/{ref_string}/{path}") |
There was a problem hiding this comment.
It works better in Positron to not surround this with <>, i.e. the automatic hyperlink detection copes better with this form.
jennybc
reviewed
Jul 24, 2024
|
|
||
| path_string <- path_ext_remove(sub("^standalone-", "", basename(path))) | ||
| ref_string <- if (is.null(ref)) "" else glue(', ref = "{ref}"') | ||
| host_string <- if (is.null(host) || host == "https://github.com") "" else glue(', host = "{host}"') |
There was a problem hiding this comment.
Only include host if it's something other than github.com. Only include ref if the user explicitly did so.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.