Replace STRING_PTR with STRING_PTR_RO #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
reviewed
Jun 25, 2024
src/rlang/vec.h
Outdated
| @@ -47,12 +47,12 @@ const void* r_raw_cbegin(r_obj* x) { | |||
| } | |||
| static inline | |||
| r_obj* const * r_chr_cbegin(r_obj* x) { | |||
| return (r_obj* const *) STRING_PTR(x); | |||
| return (r_obj* const *) STRING_PTR_RO(x); | |||
There was a problem hiding this comment.
The cast is no longer necessary I believe?
There was a problem hiding this comment.
Oh, thanks for catching!
yutannihilation
commented
Jun 26, 2024
| } | ||
| static inline | ||
| r_obj* const * r_list_cbegin(r_obj* x) { | ||
| #if (R_VERSION < R_Version(3, 5, 0)) | ||
| return ((r_obj* const *) STRING_PTR(x)); | ||
| return ((r_obj* const *) STRING_PTR_RO(x)); | ||
| #else | ||
| return ((r_obj* const *) DATAPTR_RO(x)); |
There was a problem hiding this comment.
Should I remove the cast in this line for consistency?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix one of many CRAN Notes related to newly-added "non-API"s.
(https://cran.r-project.org/web/checks/check_results_rlang.html)