Fix rping.c on FreeBSD #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The include directive of `netinet/in.h` must be present before `resolv.h` on FreeBSD, otherwise, the following errors will occur:
```
rping.c:82:27: error: use of undeclared identifier 'IPPROTO_TCP'
if (type == 0) { type = IPPROTO_TCP; } else { type = IPPROTO_UDP; }
^
rping.c:82:56: error: use of undeclared identifier 'IPPROTO_UDP'
if (type == 0) { type = IPPROTO_TCP; } else { type = IPPROTO_UDP; }
^
rping.c:117:24: error: variable has incomplete type 'struct sockaddr_in'
struct sockaddr_in c_address;
^
rping.c:117:12: note: forward declaration of 'struct sockaddr_in'
struct sockaddr_in c_address;
^
rping.c:128:17: error: use of undeclared identifier 'IPPROTO_UDP'
type == IPPROTO_UDP ? SOCK_DGRAM : SOCK_STREAM,
^
4 errors generated.
```
The reason is that the `resolv.h` on FreeBSD is not yet self-contained, see this bug report: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=182466
This fix was committed with the FreeBSD port `net/R-cran-pingr` in https://cgit.freebsd.org/ports/commit/?id=fce80f530301d0079d84bc4b818ba957ad29617b.
|
Thanks! I think you can merge this into #19. Could you also please also add an item to |
Will do - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The include directive of
netinet/in.hmust be present beforeresolv.hon FreeBSD, otherwise, the following errors will occur:The reason is that the
resolv.hon FreeBSD is not yet self-contained, see this bug report: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=182466This fix was committed with the FreeBSD port
net/R-cran-pingrin https://cgit.freebsd.org/ports/commit/?id=fce80f530301d0079d84bc4b818ba957ad29617b.