Avoid unlocking NULL#754
Merged
gaborcsardi merged 1 commit intor-lib:mainfrom Apr 28, 2025
Fan-iX:main
Merged
Conversation
When `options(install.lock = FALSE)` is set in `.Rprofile`, an error will be thrown when a package is successfully installed, aborting the installation of other packages. ``` Error: ! error in pak subprocess Caused by error in `filelock::unlock(lockfile)`: ! `unlock()` needs a lock object, not a file name ``` Add a NULL check to prevent this behavior.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
options(install.lock = FALSE)is set in.Rprofile, an error will be thrown when a package is successfully installed:This will abort the installation of other packages.
In
install-binary.R,lock_cachewill returnNULLifgetOption("install.lock")==FALSE, which is not a valid parameter forfilelock::unlock:pak/src/library/pkgdepends/R/install-binary.R
Lines 9 to 10 in 2c8de25
pak/src/library/pkgdepends/R/install-utils.R
Lines 58 to 67 in 2c8de25
pak/src/library/filelock/R/package.R
Lines 170 to 175 in 2c8de25
This PR adds a NULL check to avoid the error.