Lint identical(x, sort(x)) in sort_linter()
#2921
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2921 +/- ##
=======================================
Coverage 99.24% 99.24%
=======================================
Files 129 129
Lines 7282 7301 +19
=======================================
+ Hits 7227 7246 +19
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| # expression matching | ||
| expect_lint("sort(foo(x)) == foo(x)", sorted_msg, linter) | ||
| expect_lint("identical(foo(x), sort(foo(x)))", sorted_msg, linter) |
There was a problem hiding this comment.
Let's add some more tests against false positives, like identical(sort(x), y), identical(sort(foo(x)), x), and a test that this catches expressions: identical(sort(foo(x)), foo(x))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially tried to re-use the existing
sorted_xpathbut I think customizing the error message was then too messy and unclear.Fix #2908