-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore multi-string contents optionally in line_length_linter #2799
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2799 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 126 126
Lines 6893 6927 +34
=======================================
+ Hits 6869 6903 +34
Misses 24 24 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the tests I'm wondering whether all you need is supress lints if the lint line satisfies line1 < line < line2
for some //STR_CONST
?
there's also the issue of how to deal with lines like this: x <- 'long string starting on a short
line which also has long strings in
the other parts of the body' Before this rule, there's 3 lints, but under |
Closes #856. Progress on #2737