Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a few linters from efficiency tag #2655

Merged
merged 4 commits into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
* `cyclocomp_linter()` is no longer part of the default linters (#2555, @IndrajeetPatil) because the tidyverse style guide doesn't contain any guidelines on meeting certain complexity requirements. Note that users with `cyclocomp_linter()` in their configs may now need to install {cyclocomp} intentionally, in particular in CI/CD pipelines.
* `scalar_in_linter` is now configurable to allow other `%in%` like operators to be linted. The data.table operator `%chin%` is no longer linted by default; use `in_operators = "%chin%"` to continue linting it. (@F-Noelle)
* `lint()` and friends now normalize paths to forward slashes on Windows (@olivroy, #2613).
* Following linters have been removed from efficiency linters (@IndrajeetPatil, #2655):
`undesirable_function_linter()`, `undesirable_operator_linter()`, and `list_comparison_linter()`
MichaelChirico marked this conversation as resolved.
Show resolved Hide resolved
IndrajeetPatil marked this conversation as resolved.
Show resolved Hide resolved


## Bug fixes

Expand Down
6 changes: 3 additions & 3 deletions inst/lintr/linters.csv
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ length_test_linter,common_mistakes efficiency
lengths_linter,efficiency readability best_practices
library_call_linter,style best_practices readability configurable
line_length_linter,style readability default configurable
list_comparison_linter,best_practices common_mistakes efficiency
list_comparison_linter,best_practices common_mistakes
literal_coercion_linter,best_practices consistency efficiency
matrix_apply_linter,readability efficiency
missing_argument_linter,correctness common_mistakes configurable
Expand Down Expand Up @@ -108,8 +108,8 @@ terminal_close_linter,best_practices robustness
todo_comment_linter,style configurable
trailing_blank_lines_linter,style default
trailing_whitespace_linter,style default configurable
undesirable_function_linter,style efficiency configurable robustness best_practices
undesirable_operator_linter,style efficiency configurable robustness best_practices
undesirable_function_linter,style configurable robustness best_practices
undesirable_operator_linter,style configurable robustness best_practices
unnecessary_concatenation_linter,style readability efficiency configurable
unnecessary_lambda_linter,best_practices efficiency readability configurable
unnecessary_nested_if_linter,readability best_practices deprecated
Expand Down
3 changes: 0 additions & 3 deletions man/efficiency_linters.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions man/linters.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/list_comparison_linter.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/undesirable_function_linter.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/undesirable_operator_linter.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading