Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing affiliations for authors #2651

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Add missing affiliations for authors #2651

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4552389
Add missing affiliations for authors
IndrajeetPatil Sep 4, 2024
ff5530b
Mark affiliation Unknown for the time being
IndrajeetPatil Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions paper/paper.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@ authors:
affiliation: 1
orcid: 0000-0002-2739-7082
- name: Florent Angly
affiliation: ~
orcid: ~
affiliation: 6
orcid: 0000-0002-8999-0738
- name: Michael Chirico
affiliation: 2
orcid: 0000-0003-0787-087X
- name: Russ Hyde
affiliation: 5
orcid: ~
- name: Ren Kun
affiliation: ~
affiliation: 7
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renkun-ken Can you please let us know what's your current affiliation? I couldn't figure it out from your website.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend emailing directly to ask as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had written to Ren Kun, but still no response to my e-mail even after 2 weeks. I am not sure how to proceed here.

Should we retain “Unknown” as the affiliation?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems reasonable to me.

orcid: ~
- name: Indrajeet Patil
orcid: 0000-0003-1995-6531
Expand All @@ -35,6 +35,10 @@ affiliations:
name: Preisenergie GmbH, Munich, Germany
- index: 5
name: Jumping Rivers
- index: 6
name: The University of Queensland
- index: 7
name: ???
output:
md_document:
variant: "markdown"
Expand Down
20 changes: 13 additions & 7 deletions paper/paper.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
---
title: "Static Code Analysis for R"
date: "2024-06-21"
date: "2024-09-04"
tags: ["R", "linter", "tidyverse"]
authors:
- name: Jim Hester
affiliation: 1
orcid: 0000-0002-2739-7082
- name: Florent Angly
affiliation: ~
orcid: ~
affiliation: 6
orcid: 0000-0002-8999-0738
- name: Michael Chirico
affiliation: 2
orcid: 0000-0003-0787-087X
- name: Russ Hyde
affiliation: 5
orcid: ~
- name: Ren Kun
affiliation: ~
affiliation: 7
orcid: ~
- name: Indrajeet Patil
orcid: 0000-0003-1995-6531
Expand All @@ -35,6 +35,10 @@ affiliations:
name: Preisenergie GmbH, Munich, Germany
- index: 5
name: Jumping Rivers
- index: 6
name: The University of Queensland
- index: 7
name: ???
output:
md_document:
variant: "markdown"
Expand Down Expand Up @@ -106,6 +110,7 @@ lint(
text = "x >= 2.5",
linters = redundant_ifelse_linter()
)
#> ℹ No lints found.
```

- **Efficiency**
Expand Down Expand Up @@ -138,6 +143,7 @@ lint(
text = "anyNA(x)",
linters = any_is_na_linter()
)
#> ℹ No lints found.
```

- **Readability**
Expand Down Expand Up @@ -170,6 +176,7 @@ lint(
text = "x != 2",
linters = comparison_negation_linter()
)
#> ℹ No lints found.
```

- **Tidyverse style**
Expand Down Expand Up @@ -197,6 +204,7 @@ lint(
text = "my_var <- 1L",
linters = object_name_linter()
)
#> ℹ No lints found.
```

- **Common mistakes**
Expand Down Expand Up @@ -247,9 +255,6 @@ l <- list(x = TRUE, x = FALSE)
l["x"]
#> $x
#> [1] TRUE
```

``` r
l[names(l) == "x"]
#> $x
#> [1] TRUE
Expand All @@ -273,6 +278,7 @@ lint(
text = "my.var <- 1L",
linters = object_name_linter(styles = "dotted.case")
)
#> ℹ No lints found.
```

- Create new linters (by leveraging functions like
Expand Down
Loading