-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if parallel testing reduces check time in CI #2297
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
Part of the issue is that I think there's a maximum number of jobs that can be running at once -- speeding up individual jobs helps some, but I'd really like to reduce the number of jobs if some jobs are redundant. |
Agreed. But what do you think about turning on the parallel testing for |
if we could have it run in serial by default and parallel according to environment variable on GHA only (not CRAN) I think that's preferable. parallelism is often a trojan horse for headaches if we don't get a huge benefit |
Will setting something like this in if (Sys.getenv("NOT_CRAN", "true") == "true") {
Sys.setenv("TESTTHAT_PARALLEL" = "FALSE")
} |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I can reproduce this locally as well, so looks like a legit issue. ── Error (test-linter_tags.R:106:3): lintr help files are up to date ───────────
Error in `tools::Rd_db("lintr")`: installed help of package 'lintr' is corrupt
Backtrace:
▆
1. └─tools::Rd_db("lintr") at test-linter_tags.R:106:3 |
Related to #2295