Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if parallel testing reduces check time in CI #2297

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

IndrajeetPatil
Copy link
Collaborator

Related to #2295

@codecov-commenter

This comment was marked as off-topic.

@IndrajeetPatil

This comment was marked as outdated.

@MichaelChirico
Copy link
Collaborator

Part of the issue is that I think there's a maximum number of jobs that can be running at once -- speeding up individual jobs helps some, but I'd really like to reduce the number of jobs if some jobs are redundant.

@IndrajeetPatil
Copy link
Collaborator Author

Agreed. But what do you think about turning on the parallel testing for {lintr}, in general?
Do you see any downsides to it, apart from the failing workflow, which is likely to be a {testthat} bug?

@MichaelChirico
Copy link
Collaborator

if we could have it run in serial by default and parallel according to environment variable on GHA only (not CRAN) I think that's preferable. parallelism is often a trojan horse for headaches if we don't get a huge benefit

@IndrajeetPatil
Copy link
Collaborator Author

Will setting something like this in testthat.R work (parallel on for non-CRAN, but off for CRAN)?

if (Sys.getenv("NOT_CRAN", "true") == "true") {
  Sys.setenv("TESTTHAT_PARALLEL" = "FALSE")
}

@IndrajeetPatil

This comment was marked as resolved.

@AshesITR

This comment was marked as outdated.

@IndrajeetPatil

This comment was marked as outdated.

@IndrajeetPatil

This comment was marked as outdated.

@AshesITR

This comment was marked as outdated.

@IndrajeetPatil

This comment was marked as outdated.

@IndrajeetPatil IndrajeetPatil added the internals Issues related to inner workings of lintr, i.e., not user-visible label Jun 7, 2024
@IndrajeetPatil
Copy link
Collaborator Author

I can reproduce this locally as well, so looks like a legit issue.
Will have a deeper look into why this shows up only when tests are run in parallel.

── Error (test-linter_tags.R:106:3): lintr help files are up to date ───────────
Error in `tools::Rd_db("lintr")`: installed help of package 'lintr' is corrupt
Backtrace:1. └─tools::Rd_db("lintr") at test-linter_tags.R:106:3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Issues related to inner workings of lintr, i.e., not user-visible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants