Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary_lambda_linter() finds explicit return cases #2193

Merged
merged 25 commits into from
Oct 3, 2023

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Sep 19, 2023

Closes #1567

@MichaelChirico MichaelChirico changed the title Lambda multi impl unnecessary_lambda_linter() finds explicit return cases Sep 19, 2023
@MichaelChirico MichaelChirico added this to the 3.1.1 milestone Sep 19, 2023
IndrajeetPatil
IndrajeetPatil previously approved these changes Sep 20, 2023
Base automatically changed from lambda-multi to main October 2, 2023 14:45
@MichaelChirico MichaelChirico dismissed IndrajeetPatil’s stale review October 2, 2023 14:45

The base branch was changed.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Merging #2193 (b7c10ae) into main (d93437f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b7c10ae differs from pull request most recent head 9078c78. Consider uploading reports for the commit 9078c78 to get more accurate results

@@           Coverage Diff           @@
##             main    #2193   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         113      113           
  Lines        5167     5167           
=======================================
  Hits         5149     5149           
  Misses         18       18           
Files Coverage Δ
R/unnecessary_lambda_linter.R 100.00% <100.00%> (ø)

@MichaelChirico MichaelChirico merged commit 57db3b9 into main Oct 3, 2023
@MichaelChirico MichaelChirico deleted the lambda-multi-impl branch October 3, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary lambda linter misses multi-line cases
3 participants