More robust unreachable_code_linter
#2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2129 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 121 121
Lines 5232 5232
=======================================
Hits 5214 5214
Misses 18 18
|
MEO265
changed the title
unreachable_code_linter
|
Great find & thanks for fixing! Only the small change please. |
|
@MEO265 FYI we reserve the "bugs" section if the NEWS for things like "running the linter threw an unexpected error or warning". tightened logic (reduced false positives or false negatives) goes under "new/improved". |
|
(re-reading both items currently there don't belong either! sorry) |
MichaelChirico
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2127
In my opinion, statement
(position() != last() - 1 or not(following-sibling::OP-RIGHT-BRACE))is not necessary (At least with the new addition) and made no difference to the tests. If I miss something, let me know.