Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use public interface to test internal functions: Part-2 #1721

Merged
merged 3 commits into from
Oct 16, 2022
Merged

Use public interface to test internal functions: Part-2 #1721

merged 3 commits into from
Oct 16, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

Part of #1692

@IndrajeetPatil IndrajeetPatil changed the title Use public interface to test internal functions: Part-2 WIP: Use public interface to test internal functions: Part-2 Oct 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022 •
edited
Loading

Codecov Report

Merging #1721 (7952dd3) into main (7aee482) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1721   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         105      105           
  Lines        4504     4504           
=======================================
  Hits         4456     4456           
  Misses         48       48

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IndrajeetPatil IndrajeetPatil marked this pull request as ready for review October 16, 2022 19:35
@IndrajeetPatil IndrajeetPatil changed the title WIP: Use public interface to test internal functions: Part-2 Use public interface to test internal functions: Part-2 Oct 16, 2022
IndrajeetPatil
IndrajeetPatil commented Oct 16, 2022
View reviewed changes
tests/testthat/test-namespace.R
UseMethod("func")
}

expect_true(lintr:::is_s3_generic(func))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_s3_generic() is tested aplenty indirectly (e.g. in test-expect_lint.R).

AshesITR
AshesITR previously approved these changes Oct 16, 2022
View reviewed changes
@IndrajeetPatil IndrajeetPatil removed the request for review from MichaelChirico October 16, 2022 19:41
@IndrajeetPatil
Copy link
Collaborator Author

@AshesITR Sorry, made another change right when you approved, but reverted it afterwards.

@AshesITR AshesITR merged commit 49e935b into main Oct 16, 2022
@AshesITR AshesITR deleted the 1692_rm_internal_from_testing_2 branch October 16, 2022 21:09
@MichaelChirico MichaelChirico mentioned this pull request Oct 16, 2022
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshesITR AshesITR AshesITR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IndrajeetPatil @codecov-commenter @AshesITR