Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use public interface to test internal functions: Part-1 #1720

Merged
merged 3 commits into from
Oct 16, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

Part of #1692

@@ -1,18 +1,3 @@
test_that("line_info works as expected", {
expect_identical(
lintr:::line_info(integer(), type = "end"),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tested indirectly via exclude().

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Merging #1720 (c908231) into main (61cdce8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1720   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         105      105           
  Lines        4510     4510           
=======================================
  Hits         4454     4454           
  Misses         56       56           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IndrajeetPatil IndrajeetPatil merged commit b1780c0 into main Oct 16, 2022
@IndrajeetPatil IndrajeetPatil deleted the 1692_rm_unnecessary_tests branch October 16, 2022 15:19
@IndrajeetPatil IndrajeetPatil removed the request for review from MichaelChirico October 16, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants