Test server improvements #689
Conversation
* Use manual syncing instead of sleeping * Automatically track number of calls Fixes #683
* fix sync logic in stream test * safer url to avoid clashes
| @@ -60,84 +61,75 @@ test_that("can't read from a closed connection", { | |||
| }) | |||
|
|
|||
| test_that("can join lines across multiple reads", { | |||
There was a problem hiding this comment.
@shikokuchuo would you mind taking another look at this for me? It currently takes ~16s seconds which seems suspiciously like every sync() call is timing out.
There was a problem hiding this comment.
PR #701 should fix the issue with the sync functions. It basically ensures that syncs don't time out because the connection itself has yet to be established.
However I'm now getting a curious "Transferred a partial file [127.0.0.1]: transfer closed with outstanding read data remaining" error on a couple of the tests e.g. at https://github.com/shikokuchuo/httr2/actions/runs/13676334149/job/38237554007#step:6:179
Note that this particular 'can join lines across multiple reads' test passes. So it might be that something needs amending on those tests.
Fixes #683