Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better JSON deparsing for curl_translate() #617

Merged
merged 5 commits into from
Jan 6, 2025
Merged

Conversation

hadley
Copy link
Member

@hadley hadley commented Dec 24, 2024

Fixes #258

@mgirlich I'd really appreciate a review of this code once you're back from the break.

@hadley hadley requested a review from mgirlich December 24, 2024 15:21
@mgirlich
Copy link
Collaborator

mgirlich commented Jan 6, 2025

Awesome! 😄 I didn't yet know about req_body_json_modify(). When I looked it up, I found the documentation a bit confusing:

  • there are no examples
  • It says

Named components of this data can later be modified with req_body_json_modify().

But here we don't modify the data later but build it from the ground. This makes me wonder if this is really the correct name.

@hadley
Copy link
Member Author

hadley commented Jan 6, 2025

Hmmm, it's actually me who doesn't understand how it works 😬. I'll fix shortly.

@hadley hadley merged commit cd9786d into main Jan 6, 2025
11 checks passed
@hadley hadley deleted the curl-transform-json branch January 6, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

curl_translate() should deparse a JSON body
2 participants