Add support for RFC 8693 token exchange requests #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atheriel
force-pushed
the
rfc8693-token-exchange-flow
branch
from
214d728 to
1641c2a
Compare
hadley
approved these changes
Nov 14, 2024
| actor_token = NULL, | ||
| actor_token_type = NULL, | ||
| token_params = list()) { | ||
| oauth_client_get_token( |
There was a problem hiding this comment.
This implementation was much simpler than I expected 😆
This commit adds a new OAuth "flow" to perform the token exchange protocol described in RFC 8693 [0]. This is a pretty obscure and advanced OAuth feature, but I thought it would be nice to have some helpers to support it in `httr2`, anyway. I'm not aware of *that* many implementations of this RFC, though there are a few to note: - GCP uses it for a couple of identity federation features [1]. - Okta uses it for some advanced delegation features [2]. - Some open-source auth tools like Curity seem to support it [3], as do various commercial identity management platforms like Asgardeo [4]. - Posit Connect uses it to power its OAuth integration feature [5]. Closes r-lib#460. [0]: https://datatracker.ietf.org/doc/html/rfc8693 [1]: https://cloud.google.com/iam/docs/workforce-obtaining-short-lived-credentials [2]: https://developer.okta.com/docs/guides/set-up-token-exchange/main/ [3]: https://curity.io/resources/learn/token-exchange-flow/ [4]: https://wso2.com/asgardeo/docs/guides/authentication/configure-token-exchange/ [5]: https://docs.posit.co/connect/admin/integrations/oauth-integrations/ Signed-off-by: Aaron Jacobs <[email protected]>
atheriel
force-pushed
the
rfc8693-token-exchange-flow
branch
from
1641c2a to
40b2aea
Compare
|
I don't have write access to merge, you might have to do so on my behalf. |
|
I also gave you write access since you contribute quite a bit 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new OAuth "flow" to perform the token exchange protocol described in RFC 8693. This is a pretty obscure and advanced OAuth feature, but I thought it would be nice to have some helpers to support it in
httr2, anyway.I'm not aware of that many implementations of this RFC, though there are a few to note:
GCP uses it for a couple of identity federation features.
Okta uses it for some advanced delegation features.
Some open-source auth tools like Curity seem to support it, as do various commercial identity management platforms like Asgardeo.
Posit Connect uses it to power its OAuth integration feature.
Closes #460.