Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _ instead of . with base pipe #394

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

MSHelm
Copy link
Contributor

@MSHelm MSHelm commented Nov 17, 2023

Hey everyone,
thanks for the great package! While reading through the docs I noticed that the wrapping API article uses invalid base pipe syntax, fixed here.

I also noticed that the articles do not check for availability of the base pipe for evaluation of the code chunks, like you do in the vignette. If this should be done I would be happy to include this here as well :)

@hadley hadley merged commit 4a3a553 into r-lib:main Nov 17, 2023
@hadley
Copy link
Member

hadley commented Nov 17, 2023

Thanks! No need to check here because articles aren't run on older versions of R, unlike the vignettes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants