Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to generate repeated query parameters #352

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Make it easier to generate repeated query parameters #352

merged 4 commits into from
Oct 20, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Oct 17, 2023

Fixes #350

jonthegeek
jonthegeek approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was JUST working around this about a week ago. Thanks!

NEWS.md Outdated Show resolved Hide resolved
@hadley hadley requested review from mgirlich and jonthegeek October 19, 2023 17:47
@hadley
Copy link
Member Author

hadley commented Oct 19, 2023

I'm much happier with this new approach.

jonthegeek
jonthegeek approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo. This will be super useful! Wonderful timing, since I just had to look up what the heck "explode" meant for an API definition last week!

Do you want to mention the function option in the news bullet?

R/req-url.R Outdated Show resolved Hide resolved
@jonthegeek
Copy link
Contributor

BTW, this seems like the correct approach, but does it contradict https://design.tidyverse.org/independent-meaning.html ?

mgirlich
mgirlich reviewed Oct 20, 2023
View reviewed changes
R/req-url.R Outdated Show resolved Hide resolved
mgirlich
mgirlich reviewed Oct 20, 2023
View reviewed changes
R/req-url.R Outdated Show resolved Hide resolved
mgirlich
mgirlich reviewed Oct 20, 2023
View reviewed changes
R/req-url.R Outdated Show resolved Hide resolved
@hadley @jonthegeek @mgirlich
Apply suggestions from code review
1b4de4d 
Co-authored-by: Jon Harmon <[email protected]>
Co-authored-by: Maximilian Girlich <[email protected]>
@hadley
Copy link
Member Author

hadley commented Oct 20, 2023

@jonthegeek hmmm, maybe I'm splitting hairs, but I don't think this changes the meaning, it just changes how vectors are handled in the output.

@jonthegeek
Copy link
Contributor

@hadley I think you're correctly splitting hairs. It might be worth examining those hairs and mentioning them in that chapter, though 😊

@hadley hadley merged commit a04dc72 into main Oct 20, 2023
@hadley hadley deleted the query-splat branch October 20, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonthegeek jonthegeek jonthegeek approved these changes

@mgirlich mgirlich mgirlich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pass multi-value parameters as vectors to GET
3 participants
@hadley @jonthegeek @mgirlich