Recognise 127.0.0.1 as localhost

Fixes #316
r-lib · Oct 8, 2023 · a11c290 · a11c290
1 parent 88ea6c1
commit a11c290
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/R/oauth-flow-auth-code.R b/R/oauth-flow-auth-code.R
@@ -252,7 +252,7 @@ normalize_redirect_uri <- function(redirect_uri,
     lifecycle::deprecate_warn("0.3.0", "oauth_flow_auth_code(host_ip)")
   }
 
-  localhost <- parsed$hostname == "localhost"
+  localhost <- parsed$hostname %in% c("localhost", "127.0.0.1")
 
   if (localhost) {
     check_installed("httpuv", "desktop OAuth")

diff --git a/tests/testthat/test-oauth-flow-auth-code.R b/tests/testthat/test-oauth-flow-auth-code.R
@@ -56,6 +56,9 @@ test_that("adds port to localhost url", {
 
   redirect <- normalize_redirect_uri("http://localhost")
   expect_false(is.null(url_parse(redirect$uri)$port))
+
+  redirect <- normalize_redirect_uri("http://127.0.0.1")
+  expect_false(is.null(url_parse(redirect$uri)$port))
 })
 
 test_that("old args are deprecated", {