Increment version number to 3.6.5 #625
Open
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We changed to using an importFrom directive so we could mock these functions, but doing that makes a cyclic dependency if you try to calculate coverage on httr and its dependencies, because they are then load time dependencies for covr. Here we define a simple pass through function to make these functions runtime dependencies instead, which avoids the issue as they will only be loaded after httr itself is loaded. Fixes #623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed to using an importFrom directive so we could mock these functions, but doing that makes a cyclic dependency if you try to calculate coverage on httr and its dependencies, because they are then load time dependencies for covr. Here we define a simple pass through function to make these functions runtime dependencies instead, which avoids the issue as they will only be loaded after httr itself is loaded.
Fixes #623