This repository was archived by the owner on Nov 16, 2018. It is now read-only.
Adding possibility to clear the selector and the properties clearable, disabled and placeholder. #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er into develop # By Trevor Ewen (5) and others # Via Loic CHOLLIER (2) and Loïc CHOLLIER (1) * 'master' of github.com:quri/react-bootstrap-datetimepicker: Bump version to 0.0.15 Adds maxDate / minDate example Fix maxDate Brings back build settings FIX: addMinute, addHour, subtractMinute, subtractHour are now updating inputValue. This is more logical and actually follows the orginal package. Added the cjs, amd, and bower_components directories to gitignore. Updated README with new properties. Latest cjs and amd builds. Updated the changedate method to ignore disabled days. Added the props for minDate and maxDate. # Conflicts: # examples/basic/basic.jsx # package.json # src/DateTimeField.jsx
- Added disabled state.
… nothing as selected date
|
I forgot, I removed the console.log in the onChange, because sometimes I don't need any onChange handler and then the console.log will be shown all the time. Regards |
|
+1 from us. A datepicker which can have it's selectedDate value emptied is a must-have feature. Any prospects of a merge of alex1712's changes into the quri mainstream? |
|
Is there any progress on this case? Using placeholder instead of defaultText would be better, as in default text the input is not cleared when the user enter value. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again,
I did some changes which I needed in my current project and hope that could help you to keep improving :).
Here a resume of the changes:
*To be able to have selectedDate empty, I had to completely split viewDate and selectedDate along the code.
I think they are all my changes. We needed them really fast and maybe I didn't take long enought time to really check the code. But I hope that you get an idea of the features which I did and the code is helpful.
Again, thank you very much for all your work :)
Regards