Build: Add Node 18 to matrix, update default to Node 16

* Some non-CI jobs were still using a default of Node 10 or 14. * Fix warning "Node.js 12 actions are deprecated. … Please update actions/checkout, actions/setup-node, actions/cache"
qunitjs · Oct 22, 2022 · d5715a8 · d5715a8
1 parent 49b20d3
commit d5715a8
Show file tree

Hide file tree

Showing 8 changed files with 34 additions and 29 deletions.
diff --git a/.github/workflows/CI.yaml b/.github/workflows/CI.yaml
@@ -11,6 +11,11 @@ jobs:
       fail-fast: false
       matrix:
         include:
+          - name: "Linux: Node 18"
+            os: ubuntu-20.04
+            node: 18.x
+            script: npm run test-nolint
+
           - name: "Linux: Node 16"
             # Includes 'firefox', 'chromium', and more.
             # https://github.com/actions/virtual-environments/blob/ubuntu20/20220410.2/images/linux/Ubuntu2004-Readme.md
@@ -38,7 +43,7 @@ jobs:
 
           - name: "Integration"
             os: ubuntu-20.04
-            node: 14.x
+            node: 16.x
             script: npm run test-integration
 
           - name: "Windows: Node 16"
@@ -57,9 +62,9 @@ jobs:
       PUPPETEER_DOWNLOAD_PATH: "${{ github.workspace }}/.puppeteer_download"
       FORCE_COLOR: "1"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
-      - uses: actions/cache@v2
+      - uses: actions/cache@v3
         if: ${{ runner.os != 'Windows' }}
         with:
           path: |
@@ -68,7 +73,7 @@ jobs:
           key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
 
       - name: Use Node.js ${{ matrix.node }}
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3.5.0
         with:
           node-version: ${{ matrix.node }}
 
@@ -100,17 +105,17 @@ jobs:
     env:
       PUPPETEER_DOWNLOAD_PATH: "${{ github.workspace }}/.puppeteer_download"
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/cache@v2
+      - uses: actions/checkout@v3
+      - uses: actions/cache@v3
         with:
           path: |
             ~/.npm
             ${{ github.workspace }}/.puppeteer_download
           key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
-      - name: Use Node.js 10
-        uses: actions/setup-node@v2
+      - name: Use Node.js 16
+        uses: actions/setup-node@v3.5.0
         with:
-          node-version: 10.x
+          node-version: 16.x
       - name: Install mozjs
         run: |
           sudo apt-fast install -y libmozjs-68-dev

diff --git a/.github/workflows/browsers-full.yaml b/.github/workflows/browsers-full.yaml
@@ -18,19 +18,19 @@ jobs:
     env:
       PUPPETEER_DOWNLOAD_PATH: "${{ github.workspace }}/.puppeteer_download"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
-      - uses: actions/cache@v2
+      - uses: actions/cache@v3
         with:
           path: |
             ~/.npm
             ${{ github.workspace }}/.puppeteer_download
           key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
 
-      - name: Use Node.js 10
-        uses: actions/setup-node@v2
+      - name: Use Node.js 16
+        uses: actions/setup-node@v3.5.0
         with:
-          node-version: 10.x
+          node-version: 16.x
 
       - name: Prepare
         run: |

diff --git a/.github/workflows/browsers-quick.yaml b/.github/workflows/browsers-quick.yaml
@@ -10,19 +10,19 @@ jobs:
     env:
       PUPPETEER_DOWNLOAD_PATH: "${{ github.workspace }}/.puppeteer_download"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
-      - uses: actions/cache@v2
+      - uses: actions/cache@v3
         with:
           path: |
             ~/.npm
             ${{ github.workspace }}/.puppeteer_download
           key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
 
-      - name: Use Node.js 14
-        uses: actions/setup-node@v2
+      - name: Use Node.js 16
+        uses: actions/setup-node@v3.5.0
         with:
-          node-version: 14.x
+          node-version: 16.x
 
       - name: Prepare
         run: |

diff --git a/.github/workflows/coverage.yaml b/.github/workflows/coverage.yaml
@@ -10,19 +10,19 @@ jobs:
     env:
       PUPPETEER_DOWNLOAD_PATH: "${{ github.workspace }}/.puppeteer_download"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
-      - uses: actions/cache@v2
+      - uses: actions/cache@v3
         with:
           path: |
             ~/.npm
             ${{ github.workspace }}/.puppeteer_download
           key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
 
-      - name: Use Node.js 14
-        uses: actions/setup-node@v2
+      - name: Use Node.js 16
+        uses: actions/setup-node@v3.5.0
         with:
-          node-version: 14.x
+          node-version: 16.x
 
       - run: npm ci
 

diff --git a/.github/workflows/doc-search.yaml b/.github/workflows/doc-search.yaml
@@ -10,7 +10,7 @@ jobs:
     if: ${{ github.repository == 'qunitjs/qunit' }} # skip on forks, needs secret
     runs-on: ubuntu-18.04
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       # https://github.com/ruby/setup-ruby
       - uses: ruby/setup-ruby@v1

diff --git a/.github/workflows/github-pages.yaml b/.github/workflows/github-pages.yaml
@@ -12,7 +12,7 @@ jobs:
       DEPLOY_DIR: docs/_site/
       DEPLOY_BRANCH: gh-pages
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Prepare branch
         run: |

diff --git a/.github/workflows/reproducible.yaml b/.github/workflows/reproducible.yaml
@@ -16,10 +16,10 @@ jobs:
     if: ${{ github.repository == 'qunitjs/qunit' }} # skip on forks, noisy cron
     runs-on: ubuntu-20.04
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Use Node.js 16
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3.5.0
         with:
           node-version: 16.x
 

diff --git a/.github/workflows/spider-check.yaml b/.github/workflows/spider-check.yaml
@@ -20,7 +20,7 @@ jobs:
     runs-on: ubuntu-latest
     if: ${{ github.repository == 'qunitjs/qunit' }} # skip on forks, noisy cron and likely stale main branch
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           repository: qunitjs/hydra-link-checker
           ref: v1.0.2