Added schoology api's. #5
Conversation
There was a problem hiding this comment.
Run eslint once across the files that have changed. I noticed some indentation differences and double-quotes being used for strings. You can edit the rules of the eslintrc file (if there are any differences) to be similar to our other repos to make sure that the style is consistent
| } | ||
|
|
||
| static getNonce( nonceLength ) { | ||
| return uuidV4().replace(/-/g, '').slice(-16); |
There was a problem hiding this comment.
This should use the nonceLength param to decide the length
| */ | ||
| handleError(err, code) { | ||
| if (err.response) { | ||
| switch (err.response.status) { |
There was a problem hiding this comment.
We need to handle the case where the user's oauth token expires. You can have a look at how canvas handles it, ideally we'd try to refresh it automatically a few times before throwing an error (which would take them through the oauth flow again)
| } | ||
| } | ||
|
|
||
| isTokenExpired(err) { |
There was a problem hiding this comment.
I don't think this would apply for schoology, this was a canvas-specific condition
2 participants
No description provided.