feat: add SQLiteLookup for lookup joins with SQLite database #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a new SQLiteLookup implementation to enable lookup joins against a SQLite database, complete with caching, custom query support, and identifier validation.
- Introduces
SQLiteLookup,SQLiteLookupField, andSQLiteLookupQueryFieldinsqlite.py - Provides a comprehensive test suite in
tests/test_quixstreams/test_dataframe/test_lookup_sqlite.py - Updates type hints for lookup joins to use
Mapping[str, F]and exposes new lookup classes in__init__.py
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_quixstreams/test_dataframe/test_lookup_sqlite.py | Adds end-to-end tests covering basic lookups, TTL, ordering, defaults, errors, and query fields |
| quixstreams/dataframe/joins/lookups/sqlite.py | Implements SQLite-backed lookup join, field definitions, caching, and result extraction |
| quixstreams/dataframe/joins/lookups/quix_configuration_service/lookup.py | Updates type hint for fields parameter to Mapping[str, Field] |
| quixstreams/dataframe/joins/lookups/base.py | Updates abstract join signature to accept Mapping[str, F] |
| quixstreams/dataframe/joins/lookups/init.py | Exposes the new SQLite lookup classes in the package API |
Comments suppressed due to low confidence (2)
quixstreams/dataframe/joins/lookups/sqlite.py:48
- There's no test covering the first_match_only=False path for SQLiteLookupField, which should return multiple rows; consider adding a test to verify that behavior.
class SQLiteLookupField(BaseSQLiteLookupField):
quixstreams/dataframe/joins/lookups/sqlite.py:96
- [nitpick] The parameter name 'on' is ambiguous and could be misread; consider renaming it to something more descriptive like 'key_column' or 'lookup_column'.
on: str
- Introduce SQLiteLookup, SQLiteLookupField, and SQLiteLookupQueryField for enriching streaming data using SQLite. - Support safe table/column name validation and parameterized queries to prevent SQL injection. - Implement per-field caching with configurable TTL. - Add support for both simple and advanced SQL queries in lookup joins. - Update __init__.py to export new SQLite lookup classes.
SQLite only returns basic data type. We don't need to deepcopy them Co-authored-by: Copilot <[email protected]>
This creates problem when a parent dataclass has parameters with default values and a child dataclass wants attributes without default.
… first_match_only=False
daniil-quix
force-pushed
the
quent/lookup_joins_sqlite
branch
from
280e51f to
df059ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.