ci: require node 18.18.2 for workflow jobs #5991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quisquous
added a commit
that referenced
this pull request
Dec 20, 2023
Instead of: `ts-node util/sync_files.ts` Now we must do: `node --loader=ts-node/esm util/sync_files.ts` This should work on both node 18 and node 20 (tested locally). Git workflows were pinned to 18.18.2 via #5991, but are now updated to 20 for constency. It's possible that ts-node will fix this in the future and we can remove (again) the loader param. Fixes #5910. Fixes #5989.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
Instead of: `ts-node util/sync_files.ts` Now we must do: `node --loader=ts-node/esm util/sync_files.ts` This should work on both node 18 and node 20 (tested locally). Git workflows were pinned to 18.18.2 via #5991, but are now updated to 20 for constency. It's possible that ts-node will fix this in the future and we can remove (again) the loader param. Fixes #5910. Fixes #5989. 4c5cf21
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
Instead of: `ts-node util/sync_files.ts` Now we must do: `node --loader=ts-node/esm util/sync_files.ts` This should work on both node 18 and node 20 (tested locally). Git workflows were pinned to 18.18.2 via #5991, but are now updated to 20 for constency. It's possible that ts-node will fix this in the future and we can remove (again) the loader param. Fixes #5910. Fixes #5989. 4c5cf21
github-actions bot
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Jan 5, 2024
…quous#5990) Instead of: `ts-node util/sync_files.ts` Now we must do: `node --loader=ts-node/esm util/sync_files.ts` This should work on both node 18 and node 20 (tested locally). Git workflows were pinned to 18.18.2 via quisquous#5991, but are now updated to 20 for constency. It's possible that ts-node will fix this in the future and we can remove (again) the loader param. Fixes quisquous#5910. Fixes quisquous#5989. 4c5cf21
github-actions bot
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Jan 6, 2024
…quous#5990) Instead of: `ts-node util/sync_files.ts` Now we must do: `node --loader=ts-node/esm util/sync_files.ts` This should work on both node 18 and node 20 (tested locally). Git workflows were pinned to 18.18.2 via quisquous#5991, but are now updated to 20 for constency. It's possible that ts-node will fix this in the future and we can remove (again) the loader param. Fixes quisquous#5910. Fixes quisquous#5989. 4c5cf21
github-actions bot
pushed a commit
to SiliconExarch/cactbot
that referenced
this pull request
Jan 6, 2024
…quous#5990) Instead of: `ts-node util/sync_files.ts` Now we must do: `node --loader=ts-node/esm util/sync_files.ts` This should work on both node 18 and node 20 (tested locally). Git workflows were pinned to 18.18.2 via quisquous#5991, but are now updated to 20 for constency. It's possible that ts-node will fix this in the future and we can remove (again) the loader param. Fixes quisquous#5910. Fixes quisquous#5989. 4c5cf21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without #5990, this breaks on 18.19.x and above. See: #5910.