Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove non-existent FileChanged event #5878

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

quisquous
Copy link
Owner

@quisquous quisquous commented Oct 27, 2023

It looks like this was removed in:
OverlayPlugin/OverlayPlugin#165

@github-actions github-actions bot added the test label Oct 27, 2023
@quisquous quisquous force-pushed the test_file_changed_sub branch from cdadc2b to 8522222 Compare October 27, 2023 17:45
Copy link
Collaborator

@valarnin valarnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OverlayPlugin FileChanged event was never actually fired by anything. It may have been originally added to allow for a move of cactbot's onUserFileChanged event up to OverlayPlugin, but the cactbot equivalent event is also never fired. 🤷

@quisquous quisquous merged commit ddb292a into main Nov 2, 2023
5 checks passed
@quisquous quisquous deleted the test_file_changed_sub branch November 2, 2023 17:05
github-actions bot pushed a commit that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants