raidboss: update wording for ex7 miasmic #5847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most players seem to dodge north for this (even though it makes the spread tough). Also, the current version orders the outputs by their ordering in the array, which means that sometimes the "north" direction is first and sometimes second. To add clarity, only consider safe spots on the north side of the room, and then add explicit wording for where to go. This is maybe controversial as "east wall" could be ambiguous between ENE and ESE but it felt like to me that if most people dodge north, we can just say the "north" safe spot with details in parentheses. I found this to be more clear, at least. This output strings change would also let people change to using marker names in the output strings more easily.
|
(cc @wexxlee for thoughts; sorry if this is too opinionated of a suggestion) |
|
Been moving all weekend so haven't had a chance to dive back into ex7. Conceptually makes sense to me to simplify the calls -- but I seem to remember one pattern where the only north-ish safe spot is actually WSW? I might be misremembering that though. Will try to pull my prog logs tonight and run them through emulator with this fix and make sure I'm not hallucinating. |
|
During miasmic, there's always a safe spot in the north half and a safe spot in the south half, at an exact 45º angle from each other. e.g. ENE is safe means that SSW is safe. |
wexxlee
reviewed
Oct 9, 2023
| en: 'North Wall (NNE/WSW)', | ||
| }, | ||
| dirNNW: { | ||
| en: 'North Wall (NNW/WSW)', |
There was a problem hiding this comment.
I think this should be "North Wall (NNW/ESE)".
github-actions bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
Most players seem to dodge north for this (even though it makes the spread tough). Also, the current version orders the outputs by their ordering in the array, which means that sometimes the "north" direction is first and sometimes second. To add clarity, only consider safe spots on the north side of the room, and then add explicit wording for where to go. This is maybe controversial as "east wall" could be ambiguous between ENE and ESE but it felt like to me that if most people dodge north, we can just say the "north" safe spot with details in parentheses. I found this to be more clear, at least. This output strings change would also let people change to using marker names in the output strings more easily. 7494da5
github-actions bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
Most players seem to dodge north for this (even though it makes the spread tough). Also, the current version orders the outputs by their ordering in the array, which means that sometimes the "north" direction is first and sometimes second. To add clarity, only consider safe spots on the north side of the room, and then add explicit wording for where to go. This is maybe controversial as "east wall" could be ambiguous between ENE and ESE but it felt like to me that if most people dodge north, we can just say the "north" safe spot with details in parentheses. I found this to be more clear, at least. This output strings change would also let people change to using marker names in the output strings more easily. 7494da5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most players seem to dodge north for this (even though it makes the spread tough). Also, the current version orders the outputs by their ordering in the array, which means that sometimes the "north" direction is first and sometimes second.
To add clarity, only consider safe spots on the north side of the room, and then add explicit wording for where to go.
This is maybe controversial as "east wall" could be ambiguous between ENE and ESE but it felt like to me that if most people dodge north, we can just say the "north" safe spot with details in parentheses. I found this to be more clear, at least.
This output strings change would also let people change to using marker names in the output strings more easily.