feat(get-service-versions) Add success-if-not-found parameter to return empty list instead of raising error #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rn empty list instead of raising error
int128
reviewed
Feb 4, 2025
|
|
||
| try { | ||
| namespaceDirectory = await checkoutNamespaceBranch(inputs) | ||
| } catch (error) { |
There was a problem hiding this comment.
git コマンドの失敗以外の例外もキャッチしてしまうので、下記の exec からステータスコードを受け取ってチェックする方がよいと思います。
|
|
||
| describe('getServiceVersions', () => { | ||
| it('returnes empty list if successIfNotFound', async () => { | ||
| const result = await getServiceVersions({ |
There was a problem hiding this comment.
ユニットテストはローカルで実行するので、実行環境に依存するコマンドを実行するとテスト結果が不安定になります。
実行環境に依存するテストは E2E テストで行うのが確実ですが、今回のような単純な条件分岐では省略してもよいのではないかと思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
success-if-not-foundparameter (default: true) toget-service-versions, so that it won't break deploy workflows if there is no service changed.Ref: