security: read token from QUIKDB_TOKEN env var, warn when --token flag used#10
Open
samsonajulor wants to merge 1 commit into
Open
security: read token from QUIKDB_TOKEN env var, warn when --token flag used#10samsonajulor wants to merge 1 commit into
samsonajulor wants to merge 1 commit into
Conversation
…g used Fixes #8 The --token CLI flag exposed API tokens in ps aux output and shell history. This change reads from QUIKDB_TOKEN env var first (safe for CI/CD), keeps the --token flag for convenience but prints a security warning when it is used, and documents the env var in the help output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
--tokenCLI flag exposed API tokens inps auxoutput and shell history. This fix:QUIKDB_TOKENenvironment variable first (preferred, safe for CI/CD)--tokenflag for convenience but prints a security warning to stderr when usedQUIKDB_TOKENenv var in thehelpoutputLinked Issue
Fixes #8
Testing
QUIKDB_TOKEN=mytoken quikdb-frame login— reads env var silently, no warningquikdb-frame login --token mytoken— reads flag, prints warning to stderrquikdb-frame login— falls through to interactive login as beforego build ./...passes cleanlyChecklist