convert SegmentReader into a Trait #2747
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Abstract tantivy away from its storage format, by having
SegmentReaderas trait, which provides access to things like inverted index, columnar storage and doc store. This will allow to use tantivy with a different storage format.Changes
This a first minimal PR:
SegmentReaderinto a TraitSegmentReadertoTantivySegmentReaderget_fieldnorms_readerand usefield_norm_readersinstead.SegmentReaderhas typically few function calls, so we should be able usedyn SegmentReadereverywhere instead of generics.Follow-up
Some structs returned by
SegmentReaderare still bound to the storage format, e.g.InvertedIndexReader