[#8] Add Voucher clone — single-use redemption with atomic claim guarantee - #17
Open
lincai505011-ops wants to merge 1 commit into
Open
[#8] Add Voucher clone — single-use redemption with atomic claim guarantee#17lincai505011-ops wants to merge 1 commit into
lincai505011-ops wants to merge 1 commit into
Conversation
…ic claim guarantee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the Voucher clone: single-use voucher redemption with atomic claim guarantee under concurrent load.
Design
UPDATE "Voucher" SET "redeemedBy" = $userId … WHERE "redeemedBy" IS NULL RETURNING *so Postgres serialises concurrent claimants on the row lock. No race, no 5xx.RETURNINGset → clean 404 (voucher not found) or 409 (already redeemed).Changes
prisma/schema.prismaVouchermodel —codePK,value,redeemedBy(nullable),redeemedAt,createdAtprisma/migrations/0001_voucher/migration.sqlsrc/app.tsPOST /voucher(create) andPOST /voucher/:code/redeem(atomic redeem) routes; added voucher counter to/metricsprisma/seed.tsvoucherclone in gallerytest/voucher.test.tsprobes/concurrency-voucher.mjsInvariant
20 concurrent redeems of one voucher → exactly one succeeds (200), the rest get clean 409 — zero 5xx.
Closes #8