Skip to content

Quickshell.Network NetworkManager backend #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

Quickshell.Network NetworkManager backend #96

wants to merge 28 commits into from

Conversation

cpwrs
Copy link

@cpwrs cpwrs commented Jul 6, 2025 •
edited
Loading

Work in progress NetworkManager backend.
Spec: https://networkmanager.dev/docs/api/latest/spec.html
just run -p src/network/test/network.qml

To do:

  • Network
    • devices
    • defaultWifiDevice
  • NetworkDevice
    • name
    • address
    • state
    • type
  • NetworkWifiDevice
    • disconnect
    • lastScan
    • scan
    • connect
    • networks
  • WifiNetwork
    • ssid
    • strength
    • connected

@outfoxxed
Copy link
Member

Why are we linking nm? Should be entirely over dbus

cpwrs added 7 commits July 9, 2025 14:57
@cpwrs
fix: devicetype enum matches NMDeviceType in spec
fdbdf1d
@cpwrs
style: shorten to NM
208cfd0
@cpwrs
Revert "feat(nix): nm buildInput"
2504210 
This reverts commit 8679f79.
@cpwrs
feat: AP, Wireless xml
d323881
@cpwrs
fix test
4705796
@cpwrs
feat: begin wireless
a1515c1 
NMWireless will be a property of Device (if DeviceType==Wifi). In the
future if many org.freedesktop.networkmanager.Device.* are implemented,
we can use the factory pattern to create an NMDevice with its subdevice
properties and methods.
@cpwrs
Merge branch 'quickshell-mirror:master' into nm
19ac6db
@outfoxxed
Copy link
Member

I'm not sure what stage of development you're at here and haven't checked code yet, but just so we're clear I'd like to expose this under Quickshell.Network and keep the API clean of NM specific things (an IWD backend has been requested as well).

I don't think I've made that clear so far. (If you've got any questions, @ me here or in the matrix/discord)

@outfoxxed outfoxxed force-pushed the master branch 2 times, most recently from 9d41148 to 4b35d7b Compare July 10, 2025 08:51
@cpwrs cpwrs changed the title NetworkManager Service Quickshell.Network NetworkManager backend Jul 11, 2025
@outfoxxed outfoxxed force-pushed the master branch 2 times, most recently from 525a933 to bb206e3 Compare July 13, 2025 05:02
cpwrs added 6 commits July 15, 2025 11:49
@cpwrs
disconnect
c9ece29
@cpwrs
feat: scan, lastScan, NetworkDeviceType
997f45b
@cpwrs
feat: accessPoints
560232c
@cpwrs
fix: annotate RequestScan a{sv} for qdbusxml2cpp
7090633
@cpwrs
feat: AccessPoints -> WifiNetworks
6429991 
Access point objects shouldn't be provided to the user. Instead, we
should expose WifiNetworks which represent a set of APs with the same
SSID. A WifiNetwork signal represents the maximum signal of its APs.
@cpwrs
feat: connected
61f8c8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpwrs @outfoxxed