Handle unbound canonical-distinfo-url for ql:bundle-systems of ultralisp #202
Conversation
| (defmethod slot-unbound (class (dist dist) (slot (eql 'canonical-distinfo-url))) | ||
| (declare (ignore class)) | ||
| (setf (slot-value dist 'canonical-distinfo-url) | ||
| (distinfo-subscription-url dist))) |
There was a problem hiding this comment.
Probably it is better to define :initform nil for canonical-distinfo-url slot.
Or if it is really should be replaces by distinfo-subscription-url if unbound, then to define a canonical-distinfo-url :around accessor method.
There was a problem hiding this comment.
Thanks for commenting.
methods on slot-unbound seemed to have been an established pattern from the rest of the sources. An initform of nil would also fix the ql abort though initforms are not used on any other slot in that class (or throughout much of the rest of the ql classes for that matter)
Another option would be to make bundle.lisp specifically tolerant of the unbound slot. The value it provides to the bundle operation when correct is only a slightly more complete metadata auxiliary file.
Or simply ignore and hope that the ultralisp distinfo.txt will include a canonical-distinfo-url in the future.
I'll update this pull branch if someone can say specifically the preferred implementation. I just wanted to make this problem and a potential solution known. I've just hacked my own ~/quicklisp/quicklisp/* to get by and moved on personally.
There was a problem hiding this comment.
Or simply ignore and hope that the ultralisp distinfo.txt will include a canonical-distinfo-url in the future.
Or you might contribute this patch yourself. Here is the places to be changed:
and
To check how it will work, you might start development version of the Ultralisp with a single docker-compose up command.
This fixes a slot unbound error when trying to use
(ql:bundle-systems)and you have ultralisp dist enabled, which does not define a canonical-distinfo-url.