refactor(util): use parse_integer from simdjson #1202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simdjson provides functions for parsing decimal integers that should run faster than manually coded equivalent. Changed parse_integer_exact to use the parse_integer function from simdjson. Due to inconsistencies between what simdjson and the original implementation consider to be an error, some pre-emptive checks are run on the input string to avoid false positives/negatives.
|
CLA Assistant Lite bot Thank you for your contribution! Like many free software projects, you must sign our Contributor License Agreement before we can accept your contribution. EDIT: All contributors have signed quick-lint-js' Contributor License Agreement (CLA-v1.md). |
|
I have read and hereby agree to quick-lint-js' Contributor License Agreement (CLA-v1.md). |
|
recheck |
|
As I wrote in the GitHub issue (#915), I don't think reusing simdjson makes sense for us. I am therefore won't merge your changes and am closing this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simdjson provides functions for parsing decimal integers that should run faster than manually coded equivalent. Changed parse_integer_exact to use the parse_integer function from simdjson. Due to inconsistencies between what simdjson and the original implementation consider to be an error, some pre-emptive checks are run on the input string to avoid false positives/negatives. closes #915